Support jacktrip 1.3 - Githubissues

noiseorchestra / jacktrip_pypatcher

Python scripts to autopatch a JackTrip hubserver

GNU General Public License v3.0

6 stars 1 forks source link

Support jacktrip 1.3 #93

Closed madwort closed 3 years ago

madwort commented 3 years ago

see https://github.com/madwort/jacktrip-server-automation/pull/7#issuecomment-773250548

madwort commented 3 years ago

When I was testing out this release in it's beta version the JackTrip clients had been changed from ..ffff.192.168.0.1 to __ffff.192.168.0.1 which messed up our client selecting. This would just need updating in py_patcher and making a new release.

This will be v2, I guess?

madwort commented 3 years ago

unless we can find a way to make it compatible with both? and make it 1.1?

sandreae commented 3 years ago

I recon this will do it: https://github.com/noiseorchestra/jacktrip_pypatcher/pull/94

madwort commented 3 years ago

@sandreae could you do a v1.1 release then? then I can use the tag in the deployment repo!

sandreae commented 3 years ago

Yep, done :+1:

madwort commented 3 years ago

thanks!

madwort commented 3 years ago

reopening because of https://github.com/madwort/jacktrip-server-automation/pull/7#issuecomment-780459109

madwort commented 3 years ago

How shall we do this then @sandreae ? As far as I can see, options are:

(a) support 1.2 & 1.3 - copy 1.3 to /usr/bin in my server automation scripts - I don't much fancy this option, as I prefer having stuff we've compiled ourselves in /usr/local/bin
(b) support 1.2 & 1.3 - update pypatcher service file to /usr/local/bin and update the server automation scripts to use the new pypatcher with 1.2 & merge that before merging 1.3 (so that we can always check out an old revision of those scripts & to build a server with new pypatcher but 1.2)
(c) support only 1.3 - update pypatcher service file to /usr/local/bin - we don't need 1.2 anymore, we're going forwards into the future!
(d) ...another idea...

sandreae commented 3 years ago

I would say (c) cos I don't really see any situation where we would need to run pypatcher with v1.2 anymore. v1.3 is the official JackTrip version now I think, and even if clients are using older versions it isn't a problem. What do you recon?

sandreae commented 3 years ago

(in fact, maybe it's a healthy reminder to use the newest JT if everything breaks when you don't ;-p)

madwort commented 3 years ago

alrighty! https://github.com/noiseorchestra/jacktrip_pypatcher/pull/95