Open syphoxy opened 1 year ago
Hey, I never actually use the headphone noise filter. When such a thing happens with the microphone though, we usually suggest to move the slider for the threshold to the left a little. But as I'm not on my computer right now, I can't really check if there is such a slider for the headphones as well?
it isn't happening to the microphone. the audio is distorted on the Headphones Sink passthrough device.
But as I'm not on my computer right now, I can't really check if there is such a slider for the headphones as well?
I just took a look at the program, I only see one slider for Voice Activation Threshold. I'd need to double check the code to see if that applies to only mic or also applies to headphones.
I never actually use the headphone noise filter.
Yeah... I think I tried using it once with pipewire and it didn't seem to do anything for me. I wrote it off as something that was maybe just an issue with pipewire and perhaps worked with pulseaudio.
it isn't happening to the microphone. the audio is distorted on the Headphones Sink passthrough device.
The thought here is that if the threshold is set incorrectly for the filter then there may be some distortion, regardless of if the filtering option selected.
Overall, I think we might need to decide what to do with this feature. It's not one I've ever successfully used, tried only once out of morbid curiosity, and is one that I don't see having very much value if I'm being frank. Perhaps, at a minimum, a disclaimer should be added?
is one that I don't see having very much value
Given how awful some people's microphones are and how much background noise they transmit, I actually do see a valid use-case in video-/voice-conferences, but as I'm not usually having those on my linux computer I'm not the target group for this feature.
I'm usually only using NT for filtering out noise in my own surroundings when streaming and voice-chatting at the same time (to avoid sending the same data in parallel through Discord's krisp and OBS' noisefilter plugin).
I actually love the feature because it allows me to use my speakers while on conference calls. I think we should keep it if at all possible. it's a really powerful feature I've never seen elsewhere. you can listen to music on your speakers while using a microphone and not having any of the music bleed into the microphone until you activate it with your voice.
As a workaround until this is fixed you could perhaps switch to pulseaudio?
I'll try that and report back.
you're right. as far as I can tell it works fine with PulseAudio. right now, in general, the user experience with PulseAudio appears to be better anyway.
does this make it a bug with PipeWire or a bug with NoiseTorch?
does this make it a bug with PipeWire or a bug with NoiseTorch?
yes! ;) Pipewire is still to be considered unstable as it is mostly untested.
I guess we can close this ticket then. alternatively, is there some investigation that can be done here to help create an issue for the PipeWire project?
edit: I just realized I missed the joke.
I'd like to keep the ticket open if you don't mind. At some point (after the last part of code has been cleaned that keeps us from returning to plain GPLv3), we will hopefully be able to make this project ready for stable Pipewire usage. This ticket would serve us as a reminder on what is broken.
So... this may be a bit of a meta question, but do we actually intend to support the headphones filtering? It's a feature I've all of never used, without someone to test/use/maintain it I imagine it'll just break over and over again...
Once it works, it should keep working. I figure if there are distortions and cuts, it must be a PipeWire issue.
Fair enough.
Describe the bug Audio is distorted and intermittently cuts out when application audio is routed through "NoiseTorch Headphones Sink."
To Reproduce Use normally. Ensure both Filter Microphone and Filter Headphones are checked.
Expected behavior Clear audio through headphones sink.
Screenshots N/A
Logs
Desktop:
Additional context N/A