search

noisive / stoned-crone

eVision iOS Timetable App
https://noisive.github.io/stoned-crone
2 stars 2 forks source link

Red text on login screen (one moment) #32

Closed will-shaw closed 7 years ago

BlueDrink9 commented 7 years ago

... mind explaining what this means?

BlueDrink9 commented 7 years ago

@will-shaw what was this "bug"? Was this the changing of the feedback text on the login screen to red, to represent feedback rather than the default colour associated with buttons?

will-shaw commented 7 years ago

Kind of. Perhaps something to do with Xcode 9 which seemed to have removed the preset color which was set on the label, which was now showing up red. Essentially while displaying "One moment" and "Enter your eVision details" the label was red, and wasn't updated to blue (now black) until the "Logging you in" message. While fixing this I switched the information color to black so it doesn't look like a "button" in Apple world.

BlueDrink9 commented 7 years ago

Ok. Not at all a bug, I had specifically changed it to red to make it look like feedback. I guess black works too, red just looks like errors. But errors are red anyway, right?

will-shaw commented 7 years ago

Yeh I'd say errors are red. Plus the label was only red until it is set to blue in the code, just as it says "Logging you in". I've changed it so that the info is only black with informative cues, and only red with a login error of some kind.

BlueDrink9 commented 7 years ago

haha oh, oops. My bad. Thanks!