search

noisiver / mod-assistant

The assistant is a npc spawned in the world and lets a player obtain heirlooms, glyphs, gems, utilities like faction change and race change. The player can also spend gold in order to increase their profession skills
GNU Affero General Public License v3.0
18 stars 22 forks source link

Update module #1

Closed pangolp closed 2 years ago

pangolp commented 2 years ago

Hello, the truth is that I don't really know what the module is for, but an acquaintance told me that he was using it, and I noticed that it has a structure that is not compatible with the current version of the emulator, so I simply modified the structure so that it can be used in the current version.

noisiver commented 2 years ago

I assume you're talking about incompabilities when using Docker. The module compiles fine on my end but I do not, nor will I ever, use Docker.

I will accept the workflow if that's what Docker requires, but changing the name of the sql folder I'm sorry to say I'm not going to approve. The other modules I use, aside from my own, use the same folder structure as me and I don't see why it has to be changed.

noisiver commented 2 years ago

If you could give me a valid reason as to why I should change the structure, I would consider it. I'm however not going to change it solely for Docker.

noisiver commented 2 years ago

Ignore what I said. I'm going to approve this because I remembered that I don't use the module anymore since I replaced it with a LUA script and the module should be updated for people that do use it. I apologize if my previous messages were.. harsch.

pangolp commented 2 years ago

Don't worry, anyway, the changes I proposed, are not for Docker. Since the AzerothCore community updated the API, the folder containing the SQL scripts should have that structure.

pangolp commented 2 years ago

In fact, the compilation is nearing completion. Thank you for approving the change.

pangolp commented 2 years ago

Done, the module has passed the tests. I hadn't read that the module was working with Lua. Anyway, my idea was to update it, in case someone wants to use the module without using lua.

noisiver commented 2 years ago

No, the module itself isn't working with LUA. I made a version for LUA that I use with Eluna. It's waiting for my PR for Eluna to be approved before it'll be exactly like this module. That means that this module, in fact most of my C++ modules excluding weekend bonus, should only be updated to what other people need.

pangolp commented 2 years ago

Give me the list of the modules, and if you want I will check them, I have no problem. You can leave me a message in the discord, my user is: Stevej#5879

noisiver commented 2 years ago

They're actually linked in each repository. https://github.com/tkn963/mod-assistant#my-other-modules

I can't say which ones are actually used by anyone but me but if you feel like you want to update them I wouldn't mind.

If a module has been archived, don't waste your time though.