search

noisyboiler / wampy

Websocket RPC and Pub/Sub for Python applications and microservices
Mozilla Public License 2.0
127 stars 24 forks source link

wampy 'run' command broken #108

Closed Korridzy closed 3 years ago

Korridzy commented 3 years ago

The listener started with wampy 'run' command is not listening to his theme

(venv) $ wampy run wampy_clients:Listener
gevent monkey-patched your environment
2021-03-01 18:44:59,249 INFO:logging configured
2021-03-01 18:44:59,249 INFO:wampy starting up with event loop: gevent
2021-03-01 18:44:59,354 INFO:starting CLI with args: Namespace(application=['wampy_clients:Listener'], config='./crossbar/config.json', main=<function main at 0x7fc6a57adc10>)
2021-03-01 18:44:59,354 WARNING:defaulting to IPV 4 because neither was specified.
starting up services...
2021-03-01 18:44:59,363 INFO:socket connected
2021-03-01 18:44:59,367 INFO:handshake complete: 101 : {'status_info': ['HTTP/1.1', '101', 'Switching Protocols'], 'status': 101, 'server': 'crossbar', 'upgrade': 'websocket', 'connection': 'upgrade', 'sec-websocket-protocol': 'wamp.2.json', 'sec-websocket-accept': 'lqv92pxvjug33nw61rrjonylois='}

And nothing more. Meanwhile there are messages in his theme in server log

noisyboiler commented 3 years ago

wow. good spot. hard to add test coverage to the runner. somehow, this got lost: https://github.com/noisyboiler/wampy/commit/7bc1859f7acd501d152f3f3ca05672b501b407e3 thanks for your input @Korridzy. Much appreciated.

Korridzy commented 3 years ago

Still relevant for 1.1.0 release.

Seems like not a big deal. But when a potential wampy user is facing this bug during his first try of lib, he can decide this lib is too buggy to use in project. Meanwhile it is not so bad :)