search

noisyboiler / wampy

Websocket RPC and Pub/Sub for Python applications and microservices
Mozilla Public License 2.0
127 stars 24 forks source link

Fix cli run cmd (config path for router) #26

Closed abulte closed 7 years ago

abulte commented 7 years ago

Hi,

While test-driving wampy I noticed that your run CLI command was not compatible with the (new?) way you instantiate a Crossbar router.

Fixed it quickly in this PR, hope it helps!

Cheers, Alexandre.

noisyboiler commented 7 years ago

Hi @abulte Many thanks for updating the CLI command. Yes, you're right, it is "new". The APIs have slowly been evolving into something intuitive and stable and this was one of those evolutions. However, I clearly missed this update because there is no test coverage of the CLI commands it seems ... oops! This looks correct so I'll merge this PR. I'm also going to create a contributors list and add you to the top. Thanks again

abulte commented 7 years ago

You're welcome! 👍