noisyboiler / wampy

Websocket RPC and Pub/Sub for Python applications and microservices
Mozilla Public License 2.0
127 stars 24 forks source link

unicode bug #44

Closed noisyboiler closed 6 years ago

noisyboiler commented 6 years ago

this is far from perfect. just fixes python 2.7 and is a way of appreciating the problem.

Likely still broken on Python 3

titilambert commented 6 years ago

@noisyboiler Did you look at the code in autobahn ? Maybe you can kind of "copy/paste" the frame/payload part ?

titilambert commented 6 years ago

@noisyboiler In autobahn, they process binaries and texts with different ways... this could be an answer

See here:

Compared to:

Hope this is help ...

noisyboiler commented 6 years ago

thanks @titilambert. i'll defo take a read. autobahn can be a tricky project to get your head around though, hence writing wampy in the first place :)

noisyboiler commented 6 years ago

something wrong with the Travis build of python 3.4. doesn't look to be the fault of wampy.

titilambert commented 6 years ago

@noisyboiler I just tested my own project with wampy revision c3f19cb And this is working ! (with python 3.5.4 and python 3.6.3)

noisyboiler commented 6 years ago

that's great news! i need to update my test assertion for python 2 compat. then I'll do a release.

titilambert commented 6 years ago

@noisyboiler nice ! thanks ! I can't wait !