search

noisyboiler / wampy

Websocket RPC and Pub/Sub for Python applications and microservices
Mozilla Public License 2.0
127 stars 24 forks source link

Python 3.7 Support #94

Closed edstafford closed 4 years ago

edstafford commented 5 years ago

Biggest issue at the moment is usage of the reserved word async. Will update with further findings.

noisyboiler commented 5 years ago

thanks, @edstafford

I think it's a Crossbar issue though? It's not on their build job: https://travis-ci.org/crossbario/crossbar, and although wampy is not tested on 3.7, it does not use that keyword.

Whilst neither project is yet able to officially support 3.7 can you not create an env using 3.6 for now, to achieve what you need?

noisyboiler commented 5 years ago

wanna add 3.7 to the wampyTravis build so we can see the results?

edstafford commented 5 years ago

You are correct, I didn't read the stack trace correctly.

edstafford commented 5 years ago

I think if we could remove the direct dependency on crossbar that we could move the library forward faster.

noisyboiler commented 5 years ago

that's a good idea 👍

noisyboiler commented 4 years ago

@edstafford tests pass on 3.7 and 3.7.3 now. it's only taken a year and a half!

edstafford commented 4 years ago

I'm glad I could help! :(