noisymime / speeduino

Speeduino - Arduino based engine management
http://speeduino.com
GNU General Public License v2.0
1.31k stars 526 forks source link

Protocol error on TunerStudio while changing large areas of maps #774

Closed sokerer closed 2 years ago

sokerer commented 2 years ago

As shown in the following pictures, on the latest firmware releases, if we attempt to change large ares of the maps with < > cursors on the keyboard, a protocol error appears, and a reset of the bard is required in order to reinitiate the com. This was not happening with the previous firmwares, attempt was done on 3 different genuine arduino mega boards, and 2 different usb cables. Tests were done after a fresh install with speedyloader of the latest 202202 firmware, with relative ini file, and base tune Comunication error Speeduino v2 Comunication error Speeduino v1

adbancroft commented 2 years ago

Can you try deactivating the NEW_COMMS feature in Project Properties?

sokerer commented 2 years ago

Yes you are right, the problem disappears with the NEW COMMS deactivated !!

NEW Comms have been there since march 2021 release ? I ask because it's from the March 2021 release, that I started to find this problem

Corey-Harding commented 2 years ago

I saw noisymime recently made a new commit on master branch after you reported the issue that may fix this. Was not sure if you noticed it.

https://github.com/noisymime/speeduino/commit/fe33785ec5abaccf675df2a2debd16a793163bed

sokerer commented 2 years ago

Yes, I just had a small test with the latest master, and looks like after Noisymine patch, the problem with the NEW COMMS is solved !!

adbancroft commented 2 years ago

If solved, could you close this?