search

noisymime / speeduino

Speeduino - Arduino based engine management
http://speeduino.com
GNU General Public License v2.0
1.31k stars 524 forks source link

8 cyl basic distributor doesn't work. #932

Open cavitating409 opened 1 year ago

cavitating409 commented 1 year ago

if you setup as basic distributor and 8 cyl. it only outputs ignition pulses on ign 1, for a few seconds, then goes to outputting 4 pulses in a row, then skips 4 pulses then repeats continuously. played with filtering, pos or neg input and output just to test. no change. change to any other number of cyl's and unit works perfectly. just obviously calculates degrees and rpm incorrectly. currently it runs great using 4 cyl. and just doing math in my head for rpm and degrees. FYI its 202207 on ua4c. high speed logger shows perfect trigger input on any cyl.

jonbills commented 1 year ago

using 'spark output mode' == single channel, right? after a quick look, I have a feeling that init.ino line 806/7 and maxignoutputs=1 and/or MAX_CRANK_ANGLE=90 isn't compatible with the ignition scheduling code at speeduino.ino line 1098

cavitating409 commented 1 year ago

Yes single

On Mon, Sep 26, 2022, 8:51 AM Jon Billings @.***> wrote:

using 'spark output mode' == single channel, right? after a quick look, I have a feeling that init.ino line 806/7 and maxignoutputs=1 and/or MAX_CRANK_ANGLE=90 isn't compatible with the ignition scheduling code at speeduino.ino line 1098

— Reply to this email directly, view it on GitHub https://github.com/noisymime/speeduino/issues/932#issuecomment-1258159212, or unsubscribe https://github.com/notifications/unsubscribe-auth/A24ETXLPFV74342UWFYMH6LWAGZ73ANCNFSM6AAAAAAQVZRFSU . You are receiving this because you authored the thread.Message ID: @.***>

noisymime commented 1 year ago

I think this is likely related to the dwell limit calculations. It only begins to occur once the dwell+spark time approaches the limit (Based on the current revolution time).

At a quick look in this code, it doesn't appear to be taking the spark duration into account in one of the calculations when Single Channel is selected as the spark mode. Will continue investigating

noisymime commented 1 year ago

Can you post your tune please

noisymime commented 1 year ago

Can you please try with the latest master code

cavitating409 commented 1 year ago

Yes I'll post tune. Not sure exactly what settings are in there now. I did move dwell down to under 1ms and maxed it out. No change, but it also does do dwell backwards so it doesn't work, clue? I need rising trigger and when I move dwell it changes the time the line is high which is while it's sparking not charging. I'm triggering an external amp so it doesn't effect me. But figured I'd mention it. I did also change to falling and dwell reverses. But doesn't fix fire 4, skip 4 issue.

On Mon, Sep 26, 2022, 7:56 PM Josh Stewart @.***> wrote:

Can you please try with the latest master code

— Reply to this email directly, view it on GitHub https://github.com/noisymime/speeduino/issues/932#issuecomment-1258864614, or unsubscribe https://github.com/notifications/unsubscribe-auth/A24ETXMTV553L56M5ZTAP3DWAJH4ZANCNFSM6AAAAAAQVZRFSU . You are receiving this because you authored the thread.Message ID: @.***>

cavitating409 commented 1 year ago

On Wed, Sep 28, 2022 at 2:13 AM Justin Pierce < @.***> wrote:

Yes I'll post tune. Not sure exactly what settings are in there now. I did move dwell down to under 1ms and maxed it out. No change, but it also does do dwell backwards so it doesn't work, clue? I need rising trigger and when I move dwell it changes the time the line is high which is while it's sparking not charging. I'm triggering an external amp so it doesn't effect me. But figured I'd mention it. I did also change to falling and dwell reverses. But doesn't fix fire 4, skip 4 issue.

On Mon, Sep 26, 2022, 7:56 PM Josh Stewart @.***> wrote:

Can you please try with the latest master code

— Reply to this email directly, view it on GitHub https://github.com/noisymime/speeduino/issues/932#issuecomment-1258864614, or unsubscribe https://github.com/notifications/unsubscribe-auth/A24ETXMTV553L56M5ZTAP3DWAJH4ZANCNFSM6AAAAAAQVZRFSU . You are receiving this because you authored the thread.Message ID: @.***>

noisymime commented 1 year ago

Did you have a chance to test with the latest code on master? Assuming it’s the same issue, it should be resolved now.

cavitating409 commented 1 year ago

Haven't been near it. What do you mean by on master?

On Tue, Sep 27, 2022, 4:18 PM Josh Stewart @.***> wrote:

Did you have a chance to test with the latest code on master? Assuming it’s the same issue, it should be resolved now.

— Reply to this email directly, view it on GitHub https://github.com/noisymime/speeduino/issues/932#issuecomment-1260117258, or unsubscribe https://github.com/notifications/unsubscribe-auth/A24ETXKV6FWYHS47I434QMTWANXDJANCNFSM6AAAAAAQVZRFSU . You are receiving this because you authored the thread.Message ID: @.***>

noisymime commented 1 year ago

I pushed a change up on the master (aka development) code that I believe should resolve this. If you want to try it, scroll to the bottom of the firmware list in SpeedyLoader and select the master firmware and load that.

cavitating409 commented 1 year ago

Will do. Thank you

On Tue, Sep 27, 2022, 5:29 PM Josh Stewart @.***> wrote:

I pushed a change up on the master (aka development) code that I believe should resolve this. If you want to try it, scroll to the bottom of the firmware list in SpeedyLoader and select the master firmware and load that.

— Reply to this email directly, view it on GitHub https://github.com/noisymime/speeduino/issues/932#issuecomment-1260177752, or unsubscribe https://github.com/notifications/unsubscribe-auth/A24ETXPANSIW2JSL5RAUDC3WAN7NNANCNFSM6AAAAAAQVZRFSU . You are receiving this because you authored the thread.Message ID: @.***>

foppert commented 1 year ago

I don't know if its helpful, I found for my V8 single coil setup I had to run with "new ignition mode" disabled. If I had "new ignition mode" enabled the car would idle ok but any revs would result in backfiring and clear timing issues.

I'll try this updated code when I can and see if I can re-enable "new ignition mode".

noisymime commented 1 year ago

Any feedback on whether this change has made a difference?

cavitating409 commented 1 year ago

sorry i got so busy havent had a chance to test it.

foppert commented 1 year ago

Just tested newest firmware, I am still experiencing issues with new ignition mode. I have some logs and a tune... but I don't know how to post them to github. I am using dual wheel trigger, but basic distributor gives me the same result.