noitcudni / google-takeout-mileage-and-timeline-exporter-extension

8 stars 1 forks source link

Duration and Start/End Time Problem #1

Closed tillmannhartl closed 2 years ago

tillmannhartl commented 2 years ago

Duration = NaN days Start Time = Invalid date End Time = Invalid date

noitcudni commented 2 years ago

Where are you seeing that?

On Tue, Jan 4, 2022 at 6:48 PM tillmannhartl @.***> wrote:

Duration = NaN days Start Time = Invalid date End Time = Invalid date

— Reply to this email directly, view it on GitHub https://github.com/noitcudni/google-takeout-mileage-and-timeline-exporter-extension/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATIZ7NTWEB6FOYZ6AYUVTUUOWPHANCNFSM5LI3JHMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: <noitcudni/google-takeout-mileage-and-timeline-exporter-extension/issues/1 @github.com>

noitcudni commented 2 years ago

Nevermind. I believe you are referring to the Timeline tab.

Are all the rows showing invalid time? If you don't mind, can you send me your zip file? I'll try to reproduce it on my end.

Email the zip file to @.***

On Tue, Jan 4, 2022 at 7:15 PM Lih Chen @.***> wrote:

Where are you seeing that?

On Tue, Jan 4, 2022 at 6:48 PM tillmannhartl @.***> wrote:

Duration = NaN days Start Time = Invalid date End Time = Invalid date

— Reply to this email directly, view it on GitHub https://github.com/noitcudni/google-takeout-mileage-and-timeline-exporter-extension/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATIZ7NTWEB6FOYZ6AYUVTUUOWPHANCNFSM5LI3JHMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: <noitcudni/google-takeout-mileage-and-timeline-exporter-extension/issues/1 @github.com>

noitcudni commented 2 years ago

I just checked out the code. I don't calculate Duration. It's being read in from the json file directly.

On Tue, Jan 4, 2022 at 7:27 PM Lih Chen @.***> wrote:

Nevermind. I believe you are referring to the Timeline tab.

Are all the rows showing invalid time? If you don't mind, can you send me your zip file? I'll try to reproduce it on my end.

Email the zip file to @.***

On Tue, Jan 4, 2022 at 7:15 PM Lih Chen @.***> wrote:

Where are you seeing that?

On Tue, Jan 4, 2022 at 6:48 PM tillmannhartl @.***> wrote:

Duration = NaN days Start Time = Invalid date End Time = Invalid date

— Reply to this email directly, view it on GitHub https://github.com/noitcudni/google-takeout-mileage-and-timeline-exporter-extension/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATIZ7NTWEB6FOYZ6AYUVTUUOWPHANCNFSM5LI3JHMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: <noitcudni/google-takeout-mileage-and-timeline-exporter-extension/issues/1 @github.com>

krjamk commented 2 years ago

I am also seeing invalid date, invalid time and duration = nan days. This is on both tabs. I tried various time zones to make sure it wasn't something there causing the issue. Was this every resolved at all? The tool isn't really useful to me without this data.

noitcudni commented 2 years ago

Can you send me your zip file? I will try reproduce it tonight. Also tell me the date range and time zone.

Lih

On Mon, Jan 24, 2022 at 8:27 AM krjamk @.***> wrote:

I am also seeing invalid date, invalid time and duration = nan days. This is on both tabs. I tried various time zones to make sure it wasn't something there causing the issue. Was this every resolved at all? The tool isn't really useful to me without this data.

— Reply to this email directly, view it on GitHub https://github.com/noitcudni/google-takeout-mileage-and-timeline-exporter-extension/issues/1#issuecomment-1020285826, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATIZ6VXRW4TCMPNQF3KD3UXV4X7ANCNFSM5LI3JHMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: <noitcudni/google-takeout-mileage-and-timeline-exporter-extension/issues/1/1020285826 @github.com>

noitcudni commented 2 years ago

Email that to @.***

On Mon, Jan 24, 2022 at 8:29 AM Lih Chen @.***> wrote:

Can you send me your zip file? I will try reproduce it tonight. Also tell me the date range and time zone.

Lih

On Mon, Jan 24, 2022 at 8:27 AM krjamk @.***> wrote:

I am also seeing invalid date, invalid time and duration = nan days. This is on both tabs. I tried various time zones to make sure it wasn't something there causing the issue. Was this every resolved at all? The tool isn't really useful to me without this data.

— Reply to this email directly, view it on GitHub https://github.com/noitcudni/google-takeout-mileage-and-timeline-exporter-extension/issues/1#issuecomment-1020285826, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATIZ6VXRW4TCMPNQF3KD3UXV4X7ANCNFSM5LI3JHMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: <noitcudni/google-takeout-mileage-and-timeline-exporter-extension/issues/1/1020285826 @github.com>

krjamk commented 2 years ago

email sent to the email address in your profile with the file requested. I was doing Chicago for a location and was looking at 2021 date range but tried to shorten to a month as well for testing with no success.

jkrime commented 2 years ago

I have the same invalid date, time and duration error. Here's what I've experienced:

I have chosen the dates 2021 January 01 to 2021 December 31, and timezone America/NewYork. I left the times as the default times. I then imported the zip file. When the list populates I only have useable data in the columns From, To, Mode, and Distance. Start Time and End Time display invalid dates for all entries. The From and To display only the Street and house number, not city, state, and zipcode. The bigger issue is none of the rows display any date whatsoever.

noitcudni commented 2 years ago

TL/DR - I know the root cause. I'll fix it before I got to bed tonight.

@jkrime @krjamk @krjamk Thank you for your zip file. I'm able to reproduce it, and I know what the issue is.

I was expecting the time information is in unix timestamp in milliseconds; however, time's showing up as YYYY-mm-dd hh:mm:ss.

noitcudni commented 2 years ago

The bug is fixed. Please wait for version 0.4.0 to get approved by Google.

@jkrime @krjamk, I emailed you guys with additional information separately via email.