search

nojaf / redux-knockoutjs

Small proof of concept application of using reduxjs and knockoutjs
12 stars 0 forks source link

Rename 'erros' to 'errors' in mainViewModel.getState #1

Closed nwinger closed 8 years ago

nwinger commented 8 years ago

Tried creating a pull request, but access to the repo was denied. Came across a minor typo in the getState function in mainViewModel.ts, where the object return contains the name 'erros'. I assume it's supposed to be 'errors' :)

nojaf commented 8 years ago

Yep, typo indeed. Fixed it in https://github.com/nojaf/redux-knockoutjs/commit/38e1b23c5c768a0a393683d1b5fc60ce90b9d796

Did you fork the repo when trying to create a PR?

nwinger commented 8 years ago

Great. I tried a branch. Should maybe fork next time :) On Tue, 8 Mar 2016 at 22:57, Florian Verdonck notifications@github.com wrote:

Yep, typo indeed. Fixed it in 38e1b23 https://github.com/nojaf/redux-knockoutjs/commit/38e1b23c5c768a0a393683d1b5fc60ce90b9d796

Did you fork the repo when trying to create a PR?

— Reply to this email directly or view it on GitHub https://github.com/nojaf/redux-knockoutjs/issues/1#issuecomment-193985443 .

Mvh. Nicklas Winger