Open lehnerpat opened 10 years ago
Thanks for this feature.
To answer your questions:
1) yes, tests should be added in the /test/ directory. It's just a matter of adding a t-<class>.cpp
binary that use assert
to check the results. Then adding the name in the cmake configuration in the same directory. Just look at the existing tests.
2) Yes, please, you can start by using the above message as a comment.
3) I prefer to name from more general to more specific, so I would favor eoInitFilter
.
4) It would be nice to have, yes.
5) The license of the EO module should be LGPLv2, or I will not merge it because mixing license is a problem (yes we should clean the whole repository indeed).
These three classes are variants of the standard initializer (
eoInit
) and the main operators (eoMonOp
andeoQuadOp
) which filter the output individuals by a simple mechanism:C
, which takes an object of its superclass to do the actual workbool function(EOT individual)
operator()
is called onC
,false
( "not accepted" ), the created individual(s) is/are rejected andoperator()
will returnfalse
( "individual(s) unchanged" )false
( "not accepted" ), it will use the underlying initializer to create a new individual; this is repeated until the individual is acceptedSome points to consider and discuss:
eoInitFilter
be renamed toeoFilterInit
(so all classes follow a common scheme) ?eoBinOp
should be created?