nojhan / paradiseo

An evolutionary computation framework to (automatically) build fast parallel stochastic optimization solvers
https://nojhan.github.io/paradiseo/
Other
92 stars 33 forks source link

Fix absolute includes in MO module #45

Closed ropinho closed 4 years ago

ropinho commented 4 years ago

All files in MO directory was updated.

The include directives was changed from absolute to relative format. EO files inclusions in absolute format. It supposed which the Eo module is installed before than Mo module.

the EO module has also been updated. See #43 .

I tested the installation and usage after these changes and apparently is all right. The changes is not affecting the classes usability.

nojhan commented 4 years ago

Thanks for the proposal. However, I unfortunately don't think it's feasible this way, because modules that depends on EO have an /src/ subdir, which comes in the way of relative paths. We should rethink the organization of the directories before being able to do that.

For the time being, I will not do this kind of refactoring in MO without its maintener approval and a refactoring of subdirectories.

Also, those commits have a lot of conflicts with PR#43. Things to pay attention to:

To make a PR that is easy to check and merge for the maintener, forge atomic commit. At least, rebase the branch with 'git rebase -i master' and squash all commits in a single one, so that diffs would be easy to review.