search

nojhan / paradiseo

An evolutionary computation framework to (automatically) build fast parallel stochastic optimization solvers
https://nojhan.github.io/paradiseo/
Other
92 stars 33 forks source link

Allow the usage as a Git submodule #61

Closed ropinho closed 3 years ago

ropinho commented 3 years ago

Hi, I would like to use the ParadisEO as a Git submodule. I know that is possible to do it, but it requires more configuration.

In order to use ParadisEO as a Git submodule, would be interesting change the references to directory names in CMakeLists.txt files. When we try to configure all project with cmake, it tries configure the eo directory as [my-project-path]/eo instead some thing as [my-project-path]/external/paradiseo/eo.

(the path to submodule is external/paradiseo in this case).

Suggestion

The suggestion is replace the CMAKE_SOURCE_DIRs with CMAKE_CURRENT_SOURCE_DIR or PROJECT_SOURCE_DIR to cmake always configures these directories as relative path to the paradiseo repository path. This way, the following simple CMake code works:

add_subdirectory(external/paradiseo)
nojhan commented 3 years ago

That's a good fix, indeed. Just do a PR and I'll merge it. -- nojhan

On Thu, Jul 15, 2021 at 4:49 PM Ronaldd Pinho @.***> wrote:

Hi, I would like to use the ParadisEO as a Git submodule. I know that is possible to do it, but it requires more configuration.

In order to use ParadisEO as a Git submodule, would be interesting change the references to directory names in CMakeLists.txt files. When we try to configure all project with cmake, it tries configure the eo directory as [my-project-path]/eo instead some thing as [my-project-path]/external/paradiseo/eo.

(the path to submodule is external/paradiseo in this case). Suggestion

The suggestion is replace the ${CMAKE_SOURCE_DIR}s with ${CMAKE_CURRENT_SOURCE_DIR} to cmake always configures these directories as relative path to the paradiseo repository path. This way, the following simple CMake code works:

add_subdirectory(external/paradiseo)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nojhan/paradiseo/issues/61, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACFSUI4VUZTQZAJNUXWHBDTX3YQJANCNFSM5ANWXVBA .

nojhan commented 3 years ago

Merged, thanks!