FIXED bug in the implem. of AdaBoostClassifier

nok / sklearn-porter

Transpile trained scikit-learn estimators to C, Java, JavaScript and others.

BSD 3-Clause "New" or "Revised" License

1.28k stars 170 forks source link

FIXED bug in the implem. of AdaBoostClassifier #12

Closed mesarpe closed 7 years ago

mesarpe commented 7 years ago

Functions predict_* were named predict_1, predict_2, ..., predict_9, but when they were called the format was the following _01, _02, ... _09. This patch unifies the naming structure. I don't understand why the developer wished to name them _01 and not directly _1.

nok commented 7 years ago

Good point! I would remove the unnecessary zeros too. Can you refactor your PR please? If you want, I will make the necessary changes.

nok commented 7 years ago

Removed with commit https://github.com/nok/sklearn-porter/commit/f146b7b2affd55c5c1e19c832678723d5cf0db56.

Thanks for your advice and help! Darius

mesarpe commented 7 years ago

Sorry for the delay in answering! Thanks for fixing the bug!