search

nok / sklearn-porter

Transpile trained scikit-learn estimators to C, Java, JavaScript and others.
BSD 3-Clause "New" or "Revised" License
1.28k stars 170 forks source link

Support for SVC in Object Pascal #31

Closed mesarpe closed 2 years ago

mesarpe commented 6 years ago

This pull request provides support for the algorithm SVC.

To compile the algorithm, please serve of: fpc -objfpc ff.pas.

Cheers,

nok commented 6 years ago

Hello @mesarpe ,

thanks, that's an interesting PR! I will checkout and test it over the next days.

Due I'm not an expert in Object Pascal I have several questions. For instance why did you use a function construct instead of a class? Withit you could create multiple instances of the SVC estimator with different model data.

Darius

mesarpe commented 6 years ago

hi,

Thanks for the interest,

Well actually I followed the implementation of SVC for C. In there, there was a simple function and I have just copied the structure.

If you test the PR, later on you can make a list of suggestions.

Great job! Cheers,

On Fri, Mar 9, 2018, 19:25 Darius Morawiec notifications@github.com wrote:

Hello @mesarpe https://github.com/mesarpe ,

thanks, that's an interesting PR! I will checkout and test it over the next days.

Due I'm not an expert in Object Pascal I have several questions. For instance why did you use a function construct instead of a class? Withit you could create multiple instances of the SVC estimator with different model data.

Darius

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nok/sklearn-porter/pull/31#issuecomment-371902620, or mute the thread https://github.com/notifications/unsubscribe-auth/AG1QWWVPzV2Pw0m9ZidpImFEUWDO9suWks5tcskggaJpZM4SfOor .

mesarpe commented 6 years ago

Any updates?