force utf-8 on file open

nok / sklearn-porter

Transpile trained scikit-learn estimators to C, Java, JavaScript and others.

BSD 3-Clause "New" or "Revised" License

1.28k stars 170 forks source link

force utf-8 on file open #50

Closed jonaphin closed 5 years ago

jonaphin commented 5 years ago

Build was failing on JupyterLab using Python 3.6 in the backend. It seems the readme file was being read as ASCII instead of UTF-8. This commit fixes that issue.

nok commented 5 years ago

Thanks, with the next major release the support of Python 2 will be dropped. Then I will merge your PR.

nok commented 5 years ago

Thanks, I added your fix with the commit https://github.com/nok/sklearn-porter/commit/e6d93e0f08df3bf91653a13078bc95b47246b018 to the next major release.