search

nok / sklearn-porter

Transpile trained scikit-learn estimators to C, Java, JavaScript and others.
BSD 3-Clause "New" or "Revised" License
1.28k stars 170 forks source link

Ensure 3.5 compatibility #9

Closed JasonKessler closed 7 years ago

JasonKessler commented 7 years ago

It looks like Python 3.5 requires the module names to be dotted. Otherwise, it throws an error

...
from Porter import Porter
    ImportError: No module named 'Porter'
nok commented 7 years ago

Hello @JasonKessler,

thanks for the hint. Seriously I'm surprised about this error, because all tests passed successfully: https://travis-ci.org/nok/sklearn-porter/jobs/209585865#L121

Before the next release/update I will test this issue in a local test environment. Because of that I keep this issue and pull request open.

Happy coding, Darius 🌵

JasonKessler commented 7 years ago

Thanks, Darius. It surprised me as well. It's possible it's just a quirk of my Anaconda 3.5 environment.

nok commented 7 years ago

Thanks @JasonKessler for your support!

Best, Darius