search

nokeya / direct-links-out

Removes all "You are leaving our site" stuff from links
102 stars 19 forks source link

Getting 'TypeError: node.getElementsByTagName is not a function' errors #8

Closed FatOrangutan closed 8 years ago

FatOrangutan commented 8 years ago

Hello,

There are some 'TypeError: node.getElementsByTagName is not a function' errors in my Browser Console, arising from this script.

I'm on Firefox 50.0a2 (2016-09-01), Greasemonkey 3.9 and Direct Links Out 2.15.

Please look into this. Thanks.

nokeya commented 8 years ago

Hello! Can you please tell me domain(s) where you getting these errors?

2016-09-02 14:30 GMT+03:00 FatOrangutan notifications@github.com:

Hello,

There are some 'TypeError: node.getElementsByTagName is not a function' errors in my Browser Console, arising from this script.

https://camo.githubusercontent.com/c62af42b4d29d880b6b32d3d5a5ff75c0d5550b6/687474703a2f2f692e696d6775722e636f6d2f684d43754f63312e706e67

I'm on Firefox 50.0a2 (2016-09-01), Greasemonkey 3.9 and Direct Links Out 2.15.

Please look into this. Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nokeya/direct-links-out/issues/8, or mute the thread https://github.com/notifications/unsubscribe-auth/AC3IMstjtnnSKyq-QiiE8J-KMY0R8eFBks5qmAi9gaJpZM4Jzndr .

FatOrangutan commented 8 years ago

I'm getting it for instance on the following pages: https://www.google.com/#q=test and https://addons.mozilla.org/en-US/firefox/.

Are you not getting any errors on your end? I have e10s disabled, if that makes a difference.

nokeya commented 8 years ago

I cant test it right now, will test and fix next weekend

2016-09-03 3:20 GMT+03:00 FatOrangutan notifications@github.com:

I'm getting it for instance on the following pages: https://www.google.com/#q=test and https://addons.mozilla.org/en- US/firefox/.

Are you not getting any errors on your end? I have e10s disabled, if that makes a difference.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nokeya/direct-links-out/issues/8#issuecomment-244514678, or mute the thread https://github.com/notifications/unsubscribe-auth/AC3IMj4esHYuktGK-lQ7XuGQw0DA4ZCSks5qmL1KgaJpZM4Jzndr .

nokeya commented 8 years ago

Was unable to reproduce on Firefox 43, 45, 48 and 51 (Nightly). But will add some guard code, to prevent these messages and undefined behaviour.