nokia / CPU-Pooler

A Device Plugin for Kubernetes, which exposes the CPU cores as consumable Devices to the Kubernetes scheduler.
BSD 3-Clause "New" or "Revised" License
92 stars 22 forks source link

Build step of 'dep ensure --vendor-only' failed for not find project of Gopkg.toml #48

Closed abiao610 closed 4 years ago

abiao610 commented 4 years ago

Describe the bug After the build steps of 'Mutating webhook' and 'The device plugin', try to do 'dep ensure --vendor-only' but receives error saying "could not find project Gopkg.toml, use dep init to initiate a manifest".

To Reproduce Steps to reproduce the behavior:

  1. docker build -t ${DOCKER_REGISTRY}/cpu-device-webhook:${CPUPOOLER_VERSION} \ -f build/Dockerfile.webhook .
  2. docker build -t ${DOCKER_REGISTRY}/cpudp:${CPUPOOLER_VERSION} \ -f build/Dockerfile.cpudp .
  3. dep ensure --vendor-only

Expected behavior the cmd executed successfully.

Additional context Add any other context about the problem here.

Relevant SW info

Levovar commented 4 years ago

maybe pull master and re-try? :) correction was just merged yesterday

Levovar commented 4 years ago

ah if you are trying to build the process starter, just ignore the "dep" part, as it is not used anymore simply execute go build. go modules are integrated into go build command from 1.13 onward, so it should work seamlessly I will correct the documentation

abiao610 commented 4 years ago

Ok, got it. Pls close this issue.

Levovar commented 4 years ago

Replaced the incorrect reference to dep: https://github.com/nokia/CPU-Pooler/commit/21ee2538f9518452d5f507b0ebf4f932c18ca254