Reduce logging for exited/completed/not running containers

nokia / CPU-Pooler

A Device Plugin for Kubernetes, which exposes the CPU cores as consumable Devices to the Kubernetes scheduler.

BSD 3-Clause "New" or "Revised" License

93 stars 22 forks source link

Reduce logging for exited/completed/not running containers #61

Closed GCHQDeveloper028 closed 3 years ago

GCHQDeveloper028 commented 3 years ago

Hello!

Thank you for this project, I've been using it for a little while and it's working very well!

One thing I noted was that (in my deployment) there are quite a few logs generated from trying to set the CPUSet of an exited container. I've created this patch to reduce the logging generated from these exited containers & pods which I have been running and seems stable!

I'll comment inline to clarify why I made the changes

Many thanks for any consideration of this PR

Levovar commented 3 years ago

some linting issues: https://travis-ci.org/github/nokia/CPU-Pooler/builds/768561121

Levovar commented 3 years ago

@GCHQDeveloper028 if you fix the CI issues the PR could be merged

GCHQDeveloper028 commented 3 years ago

@Levovar - All fixed I think! Sorry it took a while!

Levovar commented 3 years ago

Np, honor is mine :) CI indeed passed, so merging