Cert manager v1.3 - Approval Condition

nokia / adcs-issuer

BSD 3-Clause "New" or "Revised" License

41 stars 42 forks source link

Cert manager v1.3 - Approval Condition #10

Closed JoshVanL closed 3 years ago

JoshVanL commented 3 years ago

In cert-manager v1.3, we introduced the approval mechanism. This PR adds an optional check, which is enabled by default, to wait for the presence of this Approval condition before signing.

This PR also adds RBAC which enables the internal cert-manager approver to approve all ADCS CertificateRequests.

Once this is merged and released we can move this issuer to the list of approval honoured issuers here.

@chojnack

JoshVanL commented 3 years ago

/assign @chojnack

chojnack commented 3 years ago

Thank you for your contribution. I see that the project is gaining some interest, so I have to find some time for it, or another person to take over :-)