nokia / danm-utils

BSD 3-Clause "New" or "Revised" License
6 stars 9 forks source link

Add Calico static CNI to release IPs #26

Closed eMGabriel closed 3 years ago

eMGabriel commented 3 years ago

Fixes nokia/danm-utils#24

Add Calico custom IP cleanup implementations for static CNIs

Levovar commented 3 years ago

Looks good to me generally speaking. only need to correct the V6 handling of Calico, and maybe the TODO(s) if you wanne be nice and can ship

eMGabriel commented 3 years ago

In this update I refactored to first separately handle and release IPv4 and IPv6 addresses of the DanmEp if available, try to release them and if release is successful, then use Danm's danmep.DeleteDanmEp API to remove the DanmEp or return error.