Cleaner to call static CNI specific API to release IPs (cont.)

nokia / danm-utils

BSD 3-Clause "New" or "Revised" License

6 stars 9 forks source link

Cleaner to call static CNI specific API to release IPs (cont.) #27

Closed eMGabriel closed 3 years ago

eMGabriel commented 3 years ago

Left out from nokia/danm-utils#26

Refactor interface encapsulation, using golang type assertion gives leaner code Extract danm IPAM release into ReleaseIP API implementation Add skipping empty IP for calico ReleaseIP

Cleaner cannot use danmep.DeleteDanmEp function when releasing Danm IPAM managed IPs, because it handles DanmEp IPv4 and IPv6 addresses together. Instead using ipam.Free directly enables handling DanmEp IPs separately.

eMGabriel commented 3 years ago

@Levovar Could you please review this?

TothFerenc commented 3 years ago

LGTM

Levovar commented 3 years ago

post LGTM as well 👍 noice one :)