Allign types: DanmNet, TenantNetwork, Clusternetwork

nokia / danm

TelCo grade network management in a Kubernetes cluster

BSD 3-Clause "New" or "Revised" License

373 stars 81 forks source link

Allign types: DanmNet, TenantNetwork, Clusternetwork #223

Closed eMGabriel closed 4 years ago

eMGabriel commented 4 years ago

What type of PR is this? cleanup

What does this PR give to us: Remove unnecessary duplicate definition in danm types, enabling better type handling in general.

Does this PR introduce a user-facing change?:

NONE

Levovar commented 4 years ago

did you try regenerating the client libraries with this change?

eMGabriel commented 4 years ago

Yes, I verified with manual code regeneration and no interfaces have changed. Also there is a codegen tampering verification running in travis which have passed.

Levovar commented 4 years ago

ah yeah forgot about that one :)