Open TothFerenc opened 4 years ago
so, this is the 97th line where it cores: https://github.com/nokia/danm/blob/master/cmd/svcwatcher/svcwatcher.go#L97 It is literally a library call without references to any objects I think I have already stated earlier that glog is shite :) maybe the non-newline API wouldn't core, but I absolutely refuse to deep dive into its code. solution is removing the usage of the whole library
the cannot create event remark above is more interesting for me
reg the Eventing issue: the leader election library creates an event recorder without a namespace defined, so it defaults to default but our component runs in the kube-system, so when we really want to record an event it fails something like: https://github.com/tsuru/remesher/pull/5
which is funny because as far as I can tell the Events are raised using the meta of the provided EndPointsLock: https://github.com/kubernetes/client-go/blob/00dbcca6ee44c678754d3f5fda1bd0e704b26fe2/tools/leaderelection/resourcelock/endpointslock.go#L100, and lo and behold we do set the proper namespace into the lock: https://github.com/nokia/danm/blob/master/cmd/svcwatcher/svcwatcher.go#L74
soo...
I guess others also have issues with the library :) https://bugzilla.redhat.com/show_bug.cgi?id=1842002
@TothFerenc any comments on above? I'm kind of on the opinion that this is how stuff works, and we just need to live with it
Maybe we can create a new TODO issue about log module harmonization (use the same logging engine across all DANM components), and this issue can depend on it. Of couse I will close this issue once client libraries are fixed in the meantime.
Is this a BUG REPORT or FEATURE REQUEST?: bug
What happened: Svcwatcher Pod lost master for any reason, so the process was exiting:
What you expected to happen: No core dump before exit.
How to reproduce it: It happens frequently during deployment.
Anything else we need to know?:
Environment:
danm -version
):kubectl version
):