nokia / fluent-plugin-brevity-control

BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Integer : num=0 and interval max limit #4

Open aarunkushwahaa opened 5 years ago

aarunkushwahaa commented 5 years ago
  1. When 'num' is set to zero, it doesn't allow any event to pass which is correct but it should give the brevity message for dropping all the events. No brevity dropped message for num=0 is logged. I think it's a bug.

  2. Since 'interval' denotes time, is it always in seconds? I mean plugin says that 'interval' is of type 'integer' but not of type 'time', so it's not possible to write interval as 1m or 1h rather we need to write 60 for 60s , 3600 for 1h, etc? Now i'm going to make illogical assumption. Suppose i want 'interval' just greater than INT_MAX value in that case brevity flops??