search

nokia / git-changelog-generator

Git Changelog Generator
https://pypi.python.org/pypi/gcg
BSD 3-Clause "New" or "Revised" License
14 stars 5 forks source link

Add -P --prefix option #34

Closed felfert closed 5 years ago

felfert commented 5 years ago

While figuring out why my custom tag pattern did not work, I stumbled over the prefix parameter of the TagFilter class. This turned out to be the ideal functionality to be use with this repository where the tags start with 'v'.

This PR adds a new option -P --prefix for specifying a prefix. The next PR will fix the actual bug where the custom pattern is not used when creating TagFilter object.

felfert commented 5 years ago

Wait a second with this one. I'll add a test case for that.

weakcamel commented 5 years ago

Wait a second with this one. I'll add a test case for that.

You're reading my mind :-) Thank you!

felfert commented 5 years ago

Will resubmit my other PR once this one is merged. This way I can reuse test-code from this PR in the other one.

weakcamel commented 5 years ago

Awesome work, thank you!

I vaguely recall that the tag filter functionality seemed mostly complete yet I didn't manage to test it properly before I had to switch to some other project in the past.

If you're ready to go with this one - let me know and I'll merge it in.

weakcamel commented 5 years ago

Off we go!

weakcamel commented 5 years ago

Dev version should soon be available on https://test.pypi.org/project/gcg/