search

nokia / git-changelog-generator

Git Changelog Generator
https://pypi.python.org/pypi/gcg
BSD 3-Clause "New" or "Revised" License
14 stars 5 forks source link

Fix #41 #46

Open felfert opened 5 years ago

felfert commented 5 years ago

This one supersedes PR #42 (rebased to resolve conflicts after timezone-stuff was merged)

The reason for Issue #41 is, that it assumes all tags have a date and author. However this assumption is false. Normally tags are "lightweight" which means they are only a reference to some commit. Only when using -a (annotate) during creation, tags become "heavy" which means that they have a commit message and author and a date (just like normal commits).

felfert commented 5 years ago

LOL. And the travis check failed because there is a bug in the tests for the timezones It fails when hour, minute or second is 0 ... waaaahhh :-) This check should be retriggered after applying #47 Perhaps I should start writing tests for the tests for the tests ... just kidding.