Open kaitoy opened 4 years ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
./kong/plugins/oidc/utils.lua | 1 | 98.55% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 134: | -0.6% |
Covered Lines: | 132 |
Relevant Lines: | 138 |
Are the above diffs all that is needed to get oidc plugin to go through a application proxy?
Yes, we're using these changes in our production environment.
So an issue that I have is if the proxy requires auth. when I add username and password into the proxy line it messes up the call.
for some reason it thinks the username is the short name of the host and fails
url : http://
I think you can use http_proxy_authorization
and https_proxy_authorization
. (ref. https://github.com/ledgetech/lua-resty-http#set_proxy_options)
I will try it.
Thanks! That worked. now i need to figure how to if/then the variables so it doesn't alway include them
I'm creating a commit to add http_proxy_authorization and https_proxy_authorization options.
I added the options for proxy auth and confirmed they work as expected.
This enhance enables to pass http_proxy and https_proxy options to lua-resty-openidc and use a proxy for communication with OIDC provider.