Check for true as well as 'yes' to avoid confusion

nokia / kong-oidc

OIDC plugin for Kong

Apache License 2.0

454 stars 320 forks source link

Check for true as well as 'yes' to avoid confusion #146

Open ramirezd42 opened 4 years ago

ramirezd42 commented 4 years ago

With kong in DB-free mode, if you specify bearer_only: yes in your kong.yml file, it will get parsed as true which causes the check to fail since it uses oidcConfig.bearer_only == "yes"

This can be pretty confusing and tripped me up for a bit. I propose checking for true in addition to "yes"

This resolves: https://github.com/nokia/kong-oidc/issues/144

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 144

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 96.324%

Totals
Change from base Build 134:	0.03%
Covered Lines:	393
Relevant Lines:	408

nokia / kong-oidc

Check for true as well as 'yes' to avoid confusion #146

Pull Request Test Coverage Report for Build 144

💛 - Coveralls