nokia / kong-oidc

OIDC plugin for Kong
Apache License 2.0
454 stars 321 forks source link

Recent version bumps not found in git tags or luarocks repo #60

Closed tommilligan closed 5 years ago

tommilligan commented 5 years ago

Just trying to get up and running with the plugin (looks like great work!), and noticed that the newer options such as bearer_only are not available in the luarocks repo.

For the last couple of version bumps:

there do not appear to have been any git tags or uploads to luarocks.

I don't have sight over if/how the upload process is automated, but happy to help out in any way I can? This is currently preventing me from doing an install of the latest rock (first time with lua, so if there's an obvious solution to this do let me know)

krehm commented 5 years ago

I ran into this same issue. What I ended up doing in the kong Dockerfile was change the 'luarocks install' command to 'luarocks make kong-oidc-1.1.0-0.rockspec' which caused it to use my local directory instead of pulling it down from a server. This should hold you until somone adds the missing tags. I also added a git reset 023485312746caff34067c9537d52feac1386976 command just before the luarocks make command so that the source that I get stays constant in case someone would add more commits. That commit is the current top of master.

tommilligan commented 5 years ago

@krehm thanks for the tip of luarocks make, I knew I must be missing something obvious.

At the moment I'm building from my fork due to the slow response time, but I'll still be submitting PRs back to here eventually

Trojan295 commented 5 years ago

I don't have permission on LuaRocks to upload a new version.

@phirvone @tsyrjanen , could you handle this and release from the current master?

tsyrjanen commented 5 years ago

I have not done that before, it was @phirvone who has taken care of that. I could try (I do not know if I have permission). In bad case we have to wait for @phirvone to come back from holiday.

phirvone commented 5 years ago

v1.1.0 now released and uploaded to luarocks (in luarocks version is 1.1.0-0).