Add X-Userinfo header after introspection as well as create_oidc

nokia / kong-oidc

OIDC plugin for Kong

Apache License 2.0

454 stars 321 forks source link

Add X-Userinfo header after introspection as well as create_oidc #65

Closed tommilligan closed 5 years ago

tommilligan commented 5 years ago

Currently, introspecting and validating an access token does not cause X-Userinfo to be set.

This PR:

ensures that this header is set after a successful introspection
improves testing for X-Userinfo in general

Closes #64

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 91

0 of 0 changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 95.935%

Files with Coverage Reduction	New Missed Lines	%
./kong/plugins/oidc/handler.lua	1	97.83%
<!--	Total:	1		-->

Totals
Change from base Build 89:	0.0%
Covered Lines:	118
Relevant Lines:	123

💛 - Coveralls

tommilligan commented 5 years ago

ping @Trojan295

Trojan295 commented 5 years ago

In fact the provided JWT token is not the Userinfo response, so the X-Userinfo header name could be misleading, but I like the solution, cause it's simple.