search

nokia / pygnmi

Python tools for gNMI
MIT License
28 stars 7 forks source link

Removed pyc #8

Open jgcumming opened 6 years ago

jgcumming commented 6 years ago

Removed PYC. Please review and ammend as desired. SET to follow

wisotzky commented 6 years ago

Is it intended to include gnmi_pb2.py in your delivery?

PRO: Simplifies the installation process for customers...

CON: File can be download straight from OpenConfig (gitHub) repository. If people are interested in using a different gNMI version - it might be beneficial for them to know, where to get the desired version of the .proto and .py files.

jgcumming commented 6 years ago

It wasn't intended. I did alter the URL you had in the readme which was now invalid. Actually, given the fact this changes so frequently I would be inclined to leave it in there with a note saying that it can be updated if required at the URL.

Your thoughts? Ultimately the only changes intended here were to add capabilities and get and change the structure to allow adding other modules in a more structured/simple way.

I'm not precious about it of course so feel free to make any changes you think are good

Cheers

James

On 2 July 2018 at 10:23, wiso notifications@github.com wrote:

Is it intended to include gnmi_pb2.py in your delivery?

PRO: Simplifies the installation process for customers...

CON: File can be download straight from OpenConfig (gitHub) repository. If people are interested in using a different gNMI version - it might be beneficial for them to know, where to get the desired version of the .proto and .py files.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nokia/pygnmi/pull/8#issuecomment-401730144, or mute the thread https://github.com/notifications/unsubscribe-auth/AFALfYvW3SYpeYbet9HNKfLyDjgBSb-3ks5uCeaAgaJpZM4U-7Xt .

wisotzky commented 6 years ago

Have you checked your code against both python2.7 and python3? I will do some testing later this week, before accepting this PR.

cheers wiso

jgcumming commented 6 years ago

No, only 2.7. Thanks - I know there are improvements to make but I needed get and capabilities quickly and it seemed sensible to extend yours rather than do something from scratch

On 2 July 2018 at 10:28, wiso notifications@github.com wrote:

Have you checked your code against both python2.7 and python3? I will do some testing later this week, before accepting this PR.

cheers wiso

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nokia/pygnmi/pull/8#issuecomment-401732130, or mute the thread https://github.com/notifications/unsubscribe-auth/AFALfWERMNpG3_t0uYBKvIDefqkBXPJhks5uCefJgaJpZM4U-7Xt .