nokia / wireless-suite

BSD 3-Clause "New" or "Revised" License
45 stars 28 forks source link

some problem in scripts directory related to two launch files #13

Closed ataeiamirhosein closed 3 years ago

ataeiamirhosein commented 3 years ago

hello; I am a master student of telecom in Politecnico di Milano under the supervision of prof. Giacomo Verticale and we work on this platform and edited some section that I described...

in file launch_agent.py I change some lines as below:

add from sacred.observers import MongoObserver after from sacred import Experiment for running like MongoDB observer.

in file launch_q_learn_umts_olpc.py I changed some lines as below:

if done:
    break

to

if s == num_episodes:
    break

in the section of # Collect progress because done not execute and we ran into out dimension.

thanks

alvarovalcarce commented 3 years ago

Hi, yes, you can add MongoDB observers if you want.

What is exactly the problem with the done parameter?

ataeiamirhosein commented 3 years ago

actually in the file of launch_q_learn_umts_olpc.py when running the code

if done:
    break

not execute and not break the code. so, I get an error about the dimension control

alvarovalcarce commented 3 years ago

Seems to be related to max_steps_per_episode in that script. I've changed that. Can you please pull and try again?

ataeiamirhosein commented 3 years ago

sure i will tell you asap

ataeiamirhosein commented 3 years ago

I try again and this time problem was solved perfect can you please describe about your changes?

alvarovalcarce commented 3 years ago

I just read avoided that t_max is read from the json configuration file by default (see the commit). You can, of course, change this if you need.

ataeiamirhosein commented 3 years ago

nice yes, i got it i wanna work on some new environment and agent thanks a lot for your help