nokiatech / heif

High Efficiency Image File Format
Other
1.74k stars 247 forks source link

incorrect writing and reading of rref #117

Open bradh opened 1 year ago

bradh commented 1 year ago

https://github.com/nokiatech/heif/blob/master/srcs/common/requiredreferencetypesproperty.cpp#L39

and

https://github.com/nokiatech/heif/blob/master/srcs/common/requiredreferencetypesproperty.cpp#L52

are treating the count as a 32 bit unsigned value.

Per ISO/IEC 23008-12:2022 Section 6.5.17.2 "Syntax", reference_type_count is an 8 bit unsigned value.