nokiatech / heif

High Efficiency Image File Format
Other
1.75k stars 248 forks source link

Parser SPS crash as SPS struct not init!! #27

Closed PhymurByrd closed 6 years ago

PhymurByrd commented 7 years ago

 The SequenceParameterSet is struct type, and not init while new.   if (naluHeader.mH265NalUnitType == H265NalUnitType::SPS){
SequenceParameterSet sps = new SequenceParameterSet; printf("[%s-%d]%p mSpsInferScalingListFlag(%d)\n", func, LINE, this, sps->mSpsInferScalingListFlag); parseSPS(bitstr, sps, naluHeader); removeSps(sps->mSpsId); mSpsList.push_back(sps); }

Then print log is: [parseNalUnit-457]0x7ffeefbfd7e8 mSpsInferScalingListFlag(66301659)

PhymurByrd commented 7 years ago

should change to SequenceParameterSet* sps = new SequenceParameterSet {}; with {} at the end.

nokiatech commented 6 years ago

Parsers no longer part of code base since v3.0.