search

noklesta / SublimeQuickFileCreator

Quick File Creator plugin for Sublime Text
65 stars 26 forks source link

Issue Fixes #6

Closed phaneendra closed 11 years ago

phaneendra commented 11 years ago

Issue Fixes 1) Fixed issue when project folders contained distinct multiple base directories 2) Added support for excluding deep directories. Issue #5 3) Does not ask for directories when there is only one . Issue #4 4) Fixed issue when in unsaved file. Issue #3 5) When no folders are available - creates the file or folder in the current directory.

noklesta commented 11 years ago

Hey @phaneendra, thanks a lot for all these fixes! It looks great :)

One problem, though: When I test the updated version in a project with a .git directory in the root directory, the .git directory is not excluded. Does the syntax in SublimeQuickFileCreator.sublime-settings need to change, or is it a bug?

phaneendra commented 11 years ago

@noklesta Yes It was a bug in the Regex for excluding folders. Updated the regex to be more generic not sure if there is better way "re.compile('|'.join(patterns))"

phaneendra commented 11 years ago

By the way I do not know how to fork after pull request is merged into main repo. On click of the fork button it redirects to my old forked repo. It would be good if a new forked repo was created.

noklesta commented 11 years ago

Excellent! I've merged it now. Thanks again!

Wrt what to do after a pull request has been merged, I haven't actually done it myself, but I suppose you will just have to pull changes to your fork. See e.g. this link: http://robots.thoughtbot.com/post/5133345960/keeping-a-git-fork-updated.