nokonoko / Pomf

Simple file uploading and sharing, source for the now shut down site Pomf.se
MIT License
463 stars 98 forks source link

Give ETA of upload #15

Closed zebracanevra closed 10 years ago

zebracanevra commented 10 years ago

If an upload has taken longer than 5 seconds, then maybe a countdown should be shown. A small progress bar is helpful to see, well, the progress, but not time remaining.

nokonoko commented 10 years ago

There is a progress bar, do you really need more?

zebracanevra commented 10 years ago

If I'm uploading a 50mb file on a crappy connection, and it'd take 10 minutes, then yes, I do need more. A progress bar with no actual percentage complete is super inaccurate (visually.) As I said, if an upload is short, then there is no need. If it is long, it's always good to provide as much information as possible so as to let the user know something is still happening. Speed would also be a good addition.

maybe it doesn't worry you as you expect everyone to have a fast connection...?

frwny commented 10 years ago

Didn't realise people still use dial up

zebracanevra commented 10 years ago

welcome to australia

nokonoko commented 10 years ago

maybe it doesn't worry you as you expect everyone to have a fast connection...?

I have 0,05-0,1Mbit/s up myself so please I know your pain, I don't feel a need for a percentage tho, the little progress bar will move every now and then, it's all I need.

But I'm sure this can be added because why not, @NuckChorris will however have to look into it since I don't know jack shit about the JS.

SEAPUNK commented 10 years ago

@nokonoko well, to know jack shit about the JS, the first thing you need to do is git gud :^)

zebracanevra commented 10 years ago

in all honesty, percentages aren't probably that useful. A progress bar is percentages in a less accurate form. An ETA, on the other hand, is completely different from a progress bar - one shows time, one shows progress ;) % complete would probably just add clutter.

SEAPUNK commented 10 years ago

@ZebraCanevra aight then, I might cook something up in my free time.

zebracanevra commented 10 years ago

I might've sounded a little hypocritical of myself, sorry for that... If you think percentages can be made to be look sweet, then there's definitely no downside about having that feature.

SEAPUNK commented 10 years ago

naw, I prefer progress bars over the percentages, the ETA is a better thing to add.

NuckChorris commented 10 years ago

I'll look into this in a couple weeks. I'm busy with hummingbird+stormbit+school right now. Shouldn't be too hard. I might also look into switching to Resumable.js since it's much better than my script.

Honestly, there's a lot of things I'd like to fix up still, it's just hard to find the time. Errbody want a piece o' nuck's time. I guess I should start charging! :smiley: