search

nokonoko / Pomf

Simple file uploading and sharing, source for the now shut down site Pomf.se
MIT License
465 stars 98 forks source link

Update upload.php #4

Closed benwaffle closed 10 years ago

benwaffle commented 10 years ago

database.inc.php already includes settings.inc.php

ghost commented 10 years ago

To be honest, the settings.inc.php include should remain for readability purposes. Then, when skimming the code, you know it's there, even if it's included from somewhere else.

nokonoko commented 10 years ago

Valid point, added //include_once 'includes/database.inc.php'; Included in database.inc.php.

NuckChorris commented 10 years ago

Does include_once have a performance hit?

ghost commented 10 years ago

Don't think so. Even if it does it's negligible.

NuckChorris commented 10 years ago

This is PHP, nothing is ever negligible. This change probably shaves an hour off of runtime.

nokonoko commented 10 years ago

My sides

ghost commented 10 years ago

Top kek.

Anyway, the include should remain imo

NuckChorris commented 10 years ago

He added it in a line comment, which probably suffices to demonstrate where it comes from. Bit hackish but who cares, all of PHP is a hack

nokonoko commented 10 years ago

Gotta keep Pomf ghetto ~

NuckChorris commented 10 years ago

Not ghetto enough. I'll open a pull request to put the following image in circulation under kawaii.php:

nokonoko commented 10 years ago

Cayoot

honkhonk