nokyan / resources

Keep an eye on system resources
GNU General Public License v3.0
706 stars 56 forks source link

Sidebar theming issue with libadwaita + Gradience #264

Closed stankovictab closed 3 months ago

stankovictab commented 3 months ago

Is there an existing issue for this?

Current Behavior

I'm using Gradience to change the look of libadwaita apps on my system. On Resources, the left sidebar when the app is maximized isn't being themed like the rest of the app. Works fine when in a smaller window. It's not an issue with the theme selected in Gradience as far as I can see. 2024-06-27_08-27-06 2024-06-27_08-27-16

Expected Behavior

The sidebar is themed

Steps To Reproduce

  1. Install Gradience
  2. Set a theme (in this case it's Catppuccin)
  3. Launch Resources

Environment

Flatpak 1.4.0, Nobara (Fedora) 39

Anything else?

No response

stankovictab commented 3 months ago

Happens on 1.5.0 too.

nokyan commented 3 months ago

Hi, in my testing, this issue exists also for Files and Settings, though I cannot exactly reproduce it for Resources since Gradience doesn't seem to work for Flatpaks for me. Screenshot from 2024-06-27 20-49-27 Screenshot from 2024-06-27 20-49-24 I think this might be an issue with either libadwaita or Gradience.

stankovictab commented 3 months ago

I'm using KDE so I didn't notice it on Gnome Files 😅 It must be - I'll close this issue then.

stankovictab commented 3 months ago

This does appear to be a Gradience issue. https://github.com/GradienceTeam/Gradience/issues/899 There is a temporary fix using custom CSS.

@define-color sidebar_bg_color @card_bg_color;
@define-color sidebar_fg_color @card_fg_color;
@define-color sidebar_shade_color @shade_color;
@define-color sidebar_border_color @headerbar_border_color;
@define-color sidebar_backdrop_color @headerbar_backdrop_color;