nolaneo / vemos

Virtual movie nights made easy.
https://vemos.org
148 stars 18 forks source link

Netflix: Switching episodes doesn't switch for everyone #71

Open zestyping opened 2 years ago

zestyping commented 2 years ago

Hi there! I noticed that on Netflix when I switch to a different episode, it doesn't switch on the other person's screen so we end up playing two different videos. The videos are still in sync, in the sense that the timecode matches precisely, though.

This is not a big deal because I can just ask the other folks to choose the same episode. I was wondering if this was intended to work, though. If it's still a to-do item, perhaps this could be a smallish task for a new developer? Is it as simple as sending the new URL over when the window location changes?

nolaneo commented 2 years ago

Hey @zestyping, thanks for the report! I'm glad to see people are still getting use from Vemos!

I never really thought about this use case to be honest so I wouldn't say it was ever intended to work, just it was a happy coincidence that it would keep the videos in sync after they change 😅 . Vemos has no knowledge of the underlying video, it just tries to keep the two <video> elements in sync on both browsers.

I'd need to look into it, but perhaps there's some simple generic way to know that both parties are looking at the same video. URLs may not work, as these could be different per user. Same with looking at the src attribute, I bet these could be different based on your account settings or location (e.g. HD vs SD streaming).

I'm always happy to look at PRs if anyone wants to take a look 🙂