Open bnaras opened 2 years ago
I am not sure why those deprecation warnings weren't flagged before, maybe R/compiler versions? I fixed those, rebuilt and resubmitted.
More issues noted by CRAN. @mlinderm Please fix what you can and make a PR for review, but don't merge. I will review and merge and submit it.
Please always write package names, software names and API (application programming interface) names in single quotes in title and description. e.g: --> 'C++'
If there are references describing the methods in your package, please add these in the description field of your DESCRIPTION file in the form
authors (year) <doi:...>
authors (year) <arXiv:...>
authors (year, ISBN:...)
or if those are not available: [<https:...>](https://github.com/nolanlab/Rclusterpp/issues/...)
with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for auto-linking.
(If you want to add a title as well please put it in quotes: "Title")
The Description field is intended to be a (one paragraph) description of what the package does and why it may be useful. Please add a few more details about the package functionality and implemented methods in your Description text.
Please always make sure to reset to user's options(), working directory or par() after you changed it in examples and vignettes and demos. -> tests/doRUnit.R
e.g.:
...
oldwd <- getwd()
...
setwd(...)
...
setwd(oldwd)
...
Please ensure that your functions do not write by default or in your examples/vignettes/tests in the user's home filespace (including the package directory and getwd()). This is not allowed by CRAN policies.
Please omit any default path in writing functions. In your examples/vignettes/tests you can write to tempdir().
Please do not modifiy the .GlobalEnv. This is not allowed by the CRAN policies.
Please fix and resubmit.
I addressed the first set of issues, but was not sure about:
Please ensure that your functions do not write by default or in your examples/vignettes/tests in the user's home filespace (including the package directory and getwd()). This is not allowed by CRAN policies. Please omit any default path in writing functions. In your examples/vignettes/tests you can write to tempdir().
The only function I can think of that has paths is the skeleton function, but there we use the same default arguments as the package.skeleton
function in utils.
@mlinderm You submitted this on CRAN , I approved, and it did not pass pretest checks. See message below. It passes on Windows, however, without that warning.