search

nolanlawson / blob-util

Cross-browser utils for working with binary Blobs
https://nolanlawson.github.io/blob-util
Apache License 2.0
503 stars 45 forks source link

Typescript typings #26

Closed WorldMaker closed 7 years ago

WorldMaker commented 7 years ago

I wrote some Typescript typings for this library (a .d.ts file) and was curious if you would accept a PR to add them to the project? (It's easiest to work with typings when they are included directly in the npm package.)

nolanlawson commented 7 years ago

Sorry, but I prefer to keep typescript typings maintained in a separate project by the typescript community. Thanks for offering, though! :)

nolanlawson commented 7 years ago

To explain my reasoning: I don't really know typescript, and including them in the repo means that I essentially take responsibility for them when they break. I believe the TS community is best served by managing their own typings instead of expecting JS maintainers to understand TS and manage the typings. E.g. TypeScript tools could also just automatically install typings when they detect that you have npm installed some project and the typings exist on DefinitelyTyped, typings, npm, wherever they're stored.

atrauzzi commented 7 years ago

@WorldMaker - Think you could publish those types to definitelytyped? 😄

WorldMaker commented 7 years ago

@atrauzzi: I may try again. All of my PRs lately seem to get stuck in PR purgatory there. It's way too big of a repository. I've had much more luck directly contributing to library repositories starting by asking like this issue. In the mean time, you can use typings to install from my "IndefinitivelyTyped" repository.

atrauzzi commented 7 years ago

Yeah, ideally packages would just include their own types, definitely typed is not offered as a premiere experience, but as a way to obtain a premiere experience.

TS is taking off in a big way lately, @nolanlawson - I urge you to reconsider! :)