search

nolanlawson / blob-util

Cross-browser utils for working with binary Blobs
https://nolanlawson.github.io/blob-util
Apache License 2.0
503 stars 45 forks source link

Export arrayBufferToBinaryString and binaryStringToArrayBuffer #43

Closed josephfrazier closed 6 years ago

josephfrazier commented 6 years ago

I didn't add tests because the other tests implicitly test these functions. Let me know if you'd like me to add explicit tests.

Best viewed ignoring whitespace changes: https://github.com/nolanlawson/blob-util/pull/43/files?w=1

nolanlawson commented 6 years ago

Thank you very much for the PR @josephfrazier. Any functions that are exported should also ideally be documented. I need to update the process of building the documentation though because right now it's a bit manual. I'll tinker with this a bit and then merge because I see no reason not to expose these. :)

josephfrazier commented 6 years ago

Thanks, I had completely overlooked the docs! Let me know if there's anything else I can do to help.

nolanlawson commented 6 years ago

No prob, this project was due for some housekeeping anyway. :) I'm about to release a 2.0.0 that should expose these functions, please let me know if anything is amiss!

Closing because this should be resolved in #49, thanks again for the PR!

josephfrazier commented 6 years ago

Cheers, v2 is a huge improvement!