search

nolanlawson / chord-magic

Musical chord parser, transposer, and disambiguator in JavaScript
Apache License 2.0
60 stars 5 forks source link

Switch to TypeScript #11

Closed nolanlawson closed 6 years ago

nolanlawson commented 6 years ago

I would like to use a similar method as in blob-util so that we can generate a .d.ts file and also automatically inject the documentation into the README.

mdanka commented 6 years ago

Hey @nolanlawson! I'm working on a site to create beautiful and usable guitar tabs with "syntax highlighting". One of the sub-projects would have been to create a chord parser, formatter, and auto-complete, but I was happy to see that you have already created something very thorough (and it looks excellent). If you're open to PRs and extensions, then I'd rather contribute here than create something new.

One of the first things before I can even use the library is having typings (my project is in typescript). Since it looks like you're working on switching to TypeScript, that looks like the best way to get typings (rather than a separate @types repo).

I see you've already assigned this issue to yourself. Are you looking for any help with it?

EDIT: in the meantime I created momo-chords, a typescript library for a very very large set of possible chord names.

nolanlawson commented 6 years ago

I would be happy to receive a PR for this. :) I'm not currently working on it, but it would be nice to have.

mdanka commented 6 years ago

Thanks :) In the meantime it was faster to create a separate library, with a different parsing system (Github), you can even try it here if you're interested.

nolanlawson commented 6 years ago

No problem! :) Very cool, and nice work. I think I'll close this for now, since I may not have time to work on this.