nolanlawson / cordova-plugin-sqlite-2

Native SQLite database API for Cordova/PhoneGap/Ionic, modeled after WebSQL (UNMAINTAINED)
https://nolanlawson.com/2016/04/10/introducing-the-cordova-sqlite-plugin-2/
Apache License 2.0
168 stars 28 forks source link

(Issue #43) #51

Closed tvolpatto closed 6 years ago

tvolpatto commented 7 years ago

add handling to the String null at Android

nolanlawson commented 6 years ago

Thanks very much for the PR @tvolpatto, and I appreciate the new test as well! Travis appears to be failing for unrelated reasons, so I will look into that. But assuming I can get Travis back up and running, this LGTM to merge.

nolanlawson commented 6 years ago

I managed to get the tests passing in Travis, and I also tweaked the PR a bit, but there is still a failing test ^

This appears to be due to the new null behavior, as it only fails in Android.

nolanlawson commented 6 years ago

merged in #59, thanks much. will do a release soon