search

nolanlawson / cordova-plugin-sqlite-2

Native SQLite database API for Cordova/PhoneGap/Ionic, modeled after WebSQL (UNMAINTAINED)
https://nolanlawson.com/2016/04/10/introducing-the-cordova-sqlite-plugin-2/
Apache License 2.0
168 stars 28 forks source link

add handling to the String null for Android (rebased) #59

Closed nolanlawson closed 6 years ago

nolanlawson commented 6 years ago

rebased version of #51

nolanlawson commented 6 years ago

Apparently a legit failing test:

Error: {"text1":1,"text2":"fun"} deepEqual {"id":1,"text2":"fun","text3":null}
    {anonymous}() test-bundle.js:41351

failed issue #43 - string/null
starting sqlite plugin test suite :: dedicated db test suite - in-memory :: valid read transaction
Error: {"id":"toto","text2":"haha","text3":null} deepEqual {"text1":"toto","text2":"haha"}
    {anonymous}() test-bundle.js:41385

failed valid read transaction
Error: there were failing tests
    at /Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/bin/test-appium.js:129:13
    at _fulfilled (/Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/node_modules/wd/node_modules/q/q.js:834:54)
    at self.promiseDispatch.done (/Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/node_modules/wd/node_modules/q/q.js:863:30)
    at Promise.promise.promiseDispatch (/Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/node_modules/wd/node_modules/q/q.js:796:13)
    at /Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/node_modules/wd/node_modules/q/q.js:604:44
    at runSingle (/Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/node_modules/wd/node_modules/q/q.js:137:13)
    at flush (/Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/node_modules/wd/node_modules/q/q.js:125:13)
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)
nolanlawson commented 6 years ago

Fixed that, now there is another legit failure:

starting sqlite plugin test suite :: suite2 test.attachments.js-local :: fetch atts with open_revs and missing
Error in Success callbackId: SQLitePlugin436520833 : TypeError: Cannot read property 'replace' of null
Error: Uncaught TypeError: Cannot read property 'replace' of null (file:///android_asset/www/cordova.js:315)
    global.onerror zuul-framework.js:6458

failed fetch atts with open_revs and missing
starting sqlite plugin test suite :: suite2 test.attachments.js-local :: issue 2803 should throw 412
Error: there were failing tests
    at /Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/bin/test-appium.js:129:13
    at _fulfilled (/Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/node_modules/wd/node_modules/q/q.js:834:54)
    at self.promiseDispatch.done (/Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/node_modules/wd/node_modules/q/q.js:863:30)
    at Promise.promise.promiseDispatch (/Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/node_modules/wd/node_modules/q/q.js:796:13)
    at /Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/node_modules/wd/node_modules/q/q.js:604:44
    at runSingle (/Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/node_modules/wd/node_modules/q/q.js:137:13)
    at flush (/Users/travis/build/nolanlawson/cordova-plugin-sqlite-2/node_modules/wd/node_modules/q/q.js:125:13)
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)
nolanlawson commented 6 years ago

This failure only occurs on the Android tests, so it appears to be related to this PR

nolanlawson commented 6 years ago

another try

nolanlawson commented 6 years ago

whoo, success!