search

nolanlawson / cordova-plugin-sqlite-2

Native SQLite database API for Cordova/PhoneGap/Ionic, modeled after WebSQL (UNMAINTAINED)
https://nolanlawson.com/2016/04/10/introducing-the-cordova-sqlite-plugin-2/
Apache License 2.0
168 stars 28 forks source link

Android NULL column issue #79

Closed summerswell-ie closed 3 years ago

summerswell-ie commented 3 years ago

I've just run into the same issue as platov in #43 - looking at the changes made, and subsequent changes I updated jsonArrayToStringArray to not call jsonArray.getString for a NULL value. Using this update, I am getting correctly inserted NULL values.

nolanlawson commented 3 years ago

Hi, thanks for the PR. Unfortunately it's become very difficult to run the tests for this project (every few years Apple/Google change something, so the tests break, and plus Travis CI is no longer usable). I'll try to get the tests running again.

nolanlawson commented 3 years ago

After a lot of difficulty, I was able to get the Android tests to run locally, and to write a new test to verify that this PR fixes the issue. I'll merge and publish, but after that I'm going to mark this repo as unmaintained because I don't have the energy to keep the CI tests up to date when stuff breaks every couple years (between iOS/Android/Selenium/Appium/Cordova/Node/Java/etc it's a huge house of cards).

Thanks for fixing a 5-year-old bug, though! Nice work. :slightly_smiling_face:

nolanlawson commented 3 years ago

For the record, here is the test that confirms the fix (failed before this PR, succeeds after): 0b57097

summerswell-ie commented 3 years ago

Thanks @nolanlawson! This plugin made my life a lot easier, so its the least I could do. Thanks for the work you've put in :)